Repository navigation
[Accuracy diff No.18、81、82] Fix accuracy diff for paddle.diag、paddle.diagflat API - #269
Merged
Merged
Conversation
cangtianhuang
marked this pull request as ready for review
June 16, 2025 09:50
cangtianhuang
changed the title
cangtianhuang
changed the title
|
Thanks for your contribution! |
cszdrg
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Accuracy diff
PR types
Improvements
Description
gpu
仔细检查两个 api 的 error log 后，发现是反向传播有精度差异：当且仅当 x 为 1D Tensor（paddle.diagflat 展平后均为 1D Tensor），且 offset < 0 时报错，在更新 paddle 至 0615 版本后测试全部通过，认为是已在 PaddlePaddle/Paddle#73084 修复
此外，PaddleAPITest 中对 paddle.diag API 的 torch 模拟有冗余，因此修改优化 DiagRule
重新测试 paddle.diag、paddle.diagflat 的所有 accuracy 配置，全部通过：
cpu
使用修改后的 DiagRule 后，问题无法复现
重新测试 paddle.diag 的 accuracy cpu 出错配置，全部通过：
